Skip to content

Be consistent when calculating sizes #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Be consistent when calculating sizes #262

wants to merge 1 commit into from

Conversation

gekmihesg
Copy link

Ensure that passing the size as integer yields the same result as
passing the size as float.
Also support sizes below 1 KiB.

Before:

lvm::size_to_bytes(lvm::bytes_to_size(2047))   # 1024.0
lvm::size_to_bytes(lvm::bytes_to_size(2047.0)) # 2047.0
lvm::bytes_to_size(1023) # Evaluation Error: The value '' cannot be converted to Numeric.

After:

lvm::size_to_bytes(lvm::bytes_to_size(2047))   # 2047.0
lvm::size_to_bytes(lvm::bytes_to_size(2047.0)) # 2047.0
lvm::bytes_to_size(1023) # 1023.0b

@gekmihesg
Be consistent when calculating sizes
cdf4887 
Ensure that passing the size as integer yields the same result as
passing the size as float.
Also support sizes below 1 KiB.
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gekmihesg @CLAassistant